-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] NET0460 evaluate display provider's flight data details endpoint performance #174
[uss_qualifier] NET0460 evaluate display provider's flight data details endpoint performance #174
Conversation
d7861a9
to
56e72d5
Compare
8211dbf
to
91448a4
Compare
91448a4
to
8ead60a
Compare
monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
2548546
to
faddc20
Compare
monitoring/uss_qualifier/scenarios/astm/netrid/v22a/aggregate_checks.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/v22a/aggregate_checks.md
Outdated
Show resolved
Hide resolved
faddc20
to
0fc2124
Compare
Moving this to draft, as it will need some updates once #159 is ready |
b184a0f
to
e46aa5c
Compare
e46aa5c
to
8f96ba0
Compare
Ready for another round of reviews (just updated on the latest master). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues to address before merge and some nits, otherwise LGTM.
monitoring/monitorlib/rid.py
Outdated
@@ -65,6 +65,11 @@ def read_scope(self) -> str: | |||
else: | |||
raise ValueError("Unsupported RID version '{}'".format(self)) | |||
|
|||
@property | |||
def dss_read_isa_scope(self) -> str: | |||
# Same regardless of ASTM RID version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a TODO regarding Ben's comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI (not a prereq for merging this PR)
self.session, | ||
"GET", | ||
f"/display_data/{flight_id}", | ||
scope=self.rid_version.dss_read_isa_scope, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: A few lines above the call GET /display_data?view=...
uses read_scope
. I'm aware of Ben's comment, but it may be better for the two calls to be consistent in the call they use. So maybe change the other call to use this, or put a TODO, or just put a constant with a TODO here and use it in both spots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I was pondering that: I was just wondering if the scopes should actually be different?
For v19 the read scope actually is the same as here (dss.read.identification_service_areas
)
I'll give it a try and see if anything blows up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope they should not be different, they both refer to the same definition: https://github.com/interuss/automated_testing_interfaces/blob/main/rid/v1/observation.yaml#L182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed: both calls to /display_data and /display_data/{flight_id} use the same scope (which happens to be equal in value to an F3411-19 scope, but is semantically an InterUSS RID observation automated testing API scope)
monitoring/uss_qualifier/scenarios/astm/netrid/v22a/aggregate_checks.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/v22a/aggregate_checks.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/display_data_evaluator.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/netrid/common/aggregate_checks.py
Outdated
Show resolved
Hide resolved
9bde64a
to
938a876
Compare
Cleaned up |
monitoring/uss_qualifier/scenarios/astm/netrid/v22a/aggregate_checks.md
Outdated
Show resolved
Hide resolved
d82128c
to
dc0c9ac
Compare
@mickmis : feel free to merge when ready & you think is appropriate |
632b4cf
to
c4d323d
Compare
c4d323d
to
dcb0e9d
Compare
Note that validating the performance of the DP for returning details requires us to actually generate some queries for that endpoint.
To this end we query details for each flight that is returned when checking the
display_data
endpoint.